Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix intersection type mv index's filters mutations composition #50379

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 12, 2024

What problem does this PR solve?

Issue Number: close #50380

Problem Summary:

What changed and how does it work?

fix the AND mv index filter mutations generating logic.
SELECT * FROM t WHERE 15975127 member of (domains) AND 15975128 member of (domains) AND a = 1 AND b = 2
for mv index mvi(a, domains, b)
the accessFilters should be [a = 1, ?, b = 1], here ? is pos occupation here stands for set {15975127 member of (domains), 15975128 member of (domains)}
when building index partial path, we have two mutation here
a=1 and 15975127 member of (domains) and b=2
a=1 and 15975128 member of (domains) and b=2

the generation mistake detail can ref the issue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix intersection type mv index's filters mutations composition

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2024
Copy link

tiprow bot commented Jan 12, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #50379 (bbfe789) into master (f257590) will decrease coverage by 14.6125%.
Report is 6 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50379         +/-   ##
=================================================
- Coverage   70.0546%   55.4422%   -14.6125%     
=================================================
  Files          1444       1555        +111     
  Lines        419989     587060     +167071     
=================================================
+ Hits         294222     325479      +31257     
- Misses       105461     238874     +133413     
- Partials      20306      22707       +2401     
Flag Coverage Δ
integration 36.7345% <88.2352%> (?)
unit 70.0458% <100.0000%> (-0.0088%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5567% <ø> (+5.8904%) ⬆️

@hawkingrei hawkingrei self-requested a review January 12, 2024 10:03
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2024
Copy link

ti-chi-bot bot commented Jan 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 13, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 13, 2024
Copy link

ti-chi-bot bot commented Jan 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-12 10:26:25.652828302 +0000 UTC m=+611775.237081974: ☑️ agreed by time-and-fate.
  • 2024-01-13 03:23:23.984039243 +0000 UTC m=+672793.568292929: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit d0c81e1 into pingcap:master Jan 13, 2024
22 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #50396.

@AilinKid
Copy link
Contributor Author

/run cherry-picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.6 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AND type mv index filter mutations generating logic is wrong
4 participants