-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix intersection type mv index's filters mutations composition #50379
planner: fix intersection type mv index's filters mutations composition #50379
Conversation
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50379 +/- ##
=================================================
- Coverage 70.0546% 55.4422% -14.6125%
=================================================
Files 1444 1555 +111
Lines 419989 587060 +167071
=================================================
+ Hits 294222 325479 +31257
- Misses 105461 238874 +133413
- Partials 20306 22707 +2401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
/run cherry-picker |
What problem does this PR solve?
Issue Number: close #50380
Problem Summary:
What changed and how does it work?
fix the AND mv index filter mutations generating logic.
SELECT * FROM t WHERE 15975127 member of (domains) AND 15975128 member of (domains) AND a = 1 AND b = 2
for mv index mvi(a, domains, b)
the accessFilters should be
[a = 1, ?, b = 1]
, here ? is pos occupation here stands for set{15975127 member of (domains), 15975128 member of (domains)}
when building index partial path, we have two mutation here
a=1 and 15975127 member of (domains) and b=2
a=1 and 15975128 member of (domains) and b=2
the generation mistake detail can ref the issue
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.