Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: add tests for dist role #50115

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jan 5, 2024

What problem does this PR solve?

Issue Number: ref #48795

Problem Summary:

What changed and how does it work?

  1. add tests for role.
  2. refine stm to mgr in task_table.go
    wait for disttask: fix can't reset service_scope #50108

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 5, 2024
Copy link

tiprow bot commented Jan 5, 2024

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #50115 (1cbf435) into master (1245c28) will decrease coverage by 14.6075%.
Report is 4 commits behind head on master.
The diff coverage is 53.9473%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50115         +/-   ##
=================================================
- Coverage   70.0224%   55.4150%   -14.6075%     
=================================================
  Files          1440       1551        +111     
  Lines        419404     586516     +167112     
=================================================
+ Hits         293677     325018      +31341     
- Misses       105405     238788     +133383     
- Partials      20322      22710       +2388     
Flag Coverage Δ
integration 36.6543% <28.9473%> (?)
unit 70.0189% <86.5853%> (-0.0036%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.4857% <ø> (+5.8331%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 6, 2024
Copy link

ti-chi-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2024
Copy link

ti-chi-bot bot commented Jan 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-06 09:24:10.663955901 +0000 UTC m=+89640.248209636: ☑️ agreed by AilinKid.
  • 2024-01-09 01:58:32.981862329 +0000 UTC m=+322102.566116041: ☑️ agreed by tangenta.

Copy link

tiprow bot commented Jan 9, 2024

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 1cbf435 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jan 9, 2024

/retest

Copy link

tiprow bot commented Jan 9, 2024

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jan 9, 2024

/retest

Copy link

tiprow bot commented Jan 9, 2024

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jan 9, 2024

/retest

Copy link

tiprow bot commented Jan 9, 2024

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 81f289d into pingcap:master Jan 9, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants