disttask: fix can't reset service_scope

[ywqzzy]

What problem does this PR solve?

Issue Number: close #50104

Problem Summary:
set global tidb_service_scope not take effect.
StartManager can't update role since task executor manager has already insert a row in dist_framework_meta

What changed and how does it work?

When update row in dist_framework_meta, update role.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50108 (06cbde7) into master (9b0fd9e) will decrease coverage by 12.1843%.
Report is 10 commits behind head on master.
The diff coverage is 84.3750%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50108         +/-   ##
=================================================
- Coverage   79.3229%   67.1387%   -12.1843%     
=================================================
  Files          2447       2558        +111     
  Lines        673700     842435     +168735     
=================================================
+ Hits         534399     565600      +31201     
- Misses       117932     253111     +135179     
- Partials      21369      23724       +2355     

Flag	Coverage Δ
integration	36.6041% <48.0000%> (?)
unit	79.2733% <83.8709%> (-0.0497%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	73.6130% <ø> (ø)
parser	∅ <ø> (∅)
br	70.9601% <ø> (+2.4839%)	⬆️

[Benjamin2037]

LGTM

[easonn7]

/approve

[ywqzzy]

/hold

[ywqzzy]

/retest

[tiprow]

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ywqzzy]

/unhold

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, easonn7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Benjamin2037,D3Hunter]
• pkg/disttask/OWNERS [Benjamin2037,D3Hunter]
• pkg/sessionctx/variable/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-05 06:54:13.543750664 +0000 UTC m=+2412744.580977591: ☑️ agreed by Benjamin2037.
• 2024-01-08 07:04:14.171922287 +0000 UTC m=+254043.756175974: ☑️ agreed by D3Hunter.

[ywqzzy]

/retest

[tiprow]

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ywqzzy]

/retest

[tiprow]

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.