Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: remove universal keyword #50103

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 5, 2024

What problem does this PR solve?

Issue Number: close #50066

ref #48875

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 5, 2024
@hawkingrei hawkingrei requested a review from qw4990 January 5, 2024 03:14
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 03:16:09.467557912 +0000 UTC m=+2399660.504784839: ☑️ agreed by qw4990.
  • 2024-01-05 03:21:19.517910131 +0000 UTC m=+2399970.555137084: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #50103 (db685f6) into master (17d24f4) will increase coverage by 2.6183%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50103        +/-   ##
================================================
+ Coverage   79.3175%   81.9358%   +2.6183%     
================================================
  Files          2445       2447         +2     
  Lines        673463     673677       +214     
================================================
+ Hits         534174     551983     +17809     
+ Misses       117908     100907     -17001     
+ Partials      21381      20787       -594     
Flag Coverage Δ
integration 48.6940% <ø> (?)
unit 79.2868% <100.0000%> (-0.0307%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (ø)
parser ∅ <ø> (∅)
br 71.8562% <ø> (+3.3528%) ⬆️

@easonn7
Copy link

easonn7 commented Jan 5, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, easonn7, qw4990, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@qw4990
Copy link
Contributor

qw4990 commented Jan 5, 2024

/test build

Copy link

tiprow bot commented Jan 5, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 5, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test db685f6 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hawkingrei
Copy link
Member Author

/retest

@lance6716 lance6716 changed the title pasrser: remove universal keyword parser: remove universal keyword Jan 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit b4ba24b into pingcap:master Jan 5, 2024
19 of 20 checks passed
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run make in pkg/parser will make Keywords out of order
5 participants