Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: update parser.y make keywords in the order #50069

Closed
wants to merge 1 commit into from

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50066

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2024
Copy link

tiprow bot commented Jan 4, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #50069 (0383950) into master (cdc7572) will decrease coverage by 3.1522%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50069        +/-   ##
================================================
- Coverage   71.8868%   68.7346%   -3.1522%     
================================================
  Files          1439       1441         +2     
  Lines        346158     407736     +61578     
================================================
+ Hits         248842     280256     +31414     
- Misses        77040     108461     +31421     
+ Partials      20276      19019      -1257     
Flag Coverage Δ
integration 43.8234% <ø> (?)
unit 71.8868% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.3129% <ø> (ø)
parser ∅ <ø> (∅)
br 44.0173% <ø> (-7.4564%) ⬇️

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good that we write a script or something to automatically sort them

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
Copy link

ti-chi-bot bot commented Jan 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 06:31:19.768839128 +0000 UTC m=+2324970.806066055: ☑️ agreed by tangenta.
  • 2024-01-04 13:43:49.198354768 +0000 UTC m=+2350920.235581696: ☑️ agreed by lance6716.

@easonn7
Copy link

easonn7 commented Jan 5, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@hawkingrei
Copy link
Member

It will be removed. Because the universal binding is cancelled.

@hawkingrei
Copy link
Member

universal is removed by #50103.

@hawkingrei hawkingrei closed this Jan 5, 2024
@Defined2014 Defined2014 deleted the fix-50066 branch January 5, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run make in pkg/parser will make Keywords out of order
5 participants