Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: revert mistakenly change library logger level to debug #46846

Merged
merged 1 commit into from
Sep 13, 2023
Merged

log: revert mistakenly change library logger level to debug #46846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion br/pkg/lightning/log/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func InitLogger(cfg *Config, _ string) error {
// Disable annoying TiDB Log.
// TODO: some error logs outputs randomly, we need to fix them in TiDB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we complete this TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I don't know the details about this problem

// this LEVEL only affects SlowQueryLogger, later ReplaceGlobals will overwrite it.
tidbLogCfg.Level = "debug"
tidbLogCfg.Level = "fatal"
// this also init GRPCLogger, controlled by GRPC_DEBUG env.
err := logutil.InitLogger(&tidbLogCfg)
if err != nil {
Expand Down