Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: revert mistakenly change library logger level to debug #46846

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

I forget to revert tidbLogCfg.Level = "debug" in #46726

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@lance6716 lance6716 added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@tiprow
Copy link

tiprow bot commented Sep 11, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -97,7 +97,7 @@ func InitLogger(cfg *Config, _ string) error {
// Disable annoying TiDB Log.
// TODO: some error logs outputs randomly, we need to fix them in TiDB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we complete this TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I don't know the details about this problem

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #46846 (ea118cf) into master (e76d10a) will increase coverage by 0.4477%.
Report is 47 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46846        +/-   ##
================================================
+ Coverage   73.3166%   73.7643%   +0.4477%     
================================================
  Files          1322       1352        +30     
  Lines        396479     413182     +16703     
================================================
+ Hits         290685     304781     +14096     
- Misses        87265      89949      +2684     
+ Partials      18529      18452        -77     
Flag Coverage Δ
integration 28.7841% <0.0000%> (?)
unit 74.3802% <100.0000%> (+1.0636%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.4209% <ø> (+0.4600%) ⬆️
br 49.1743% <100.0000%> (-3.4634%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @D3Hunter

@ti-chi-bot ti-chi-bot bot requested review from D3Hunter and GMHDBJD September 12, 2023 06:25
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 05:22:58.66764947 +0000 UTC m=+246760.592205866: ☑️ agreed by hawkingrei.
  • 2023-09-13 08:04:29.829053995 +0000 UTC m=+72635.796642044: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 1e4b2d2 into pingcap:master Sep 13, 2023
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants