-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: revert mistakenly change library logger level to debug #46846
Conversation
Signed-off-by: lance6716 <[email protected]>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -97,7 +97,7 @@ func InitLogger(cfg *Config, _ string) error { | |||
// Disable annoying TiDB Log. | |||
// TODO: some error logs outputs randomly, we need to fix them in TiDB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we complete this TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I don't know the details about this problem
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46846 +/- ##
================================================
+ Coverage 73.3166% 73.7643% +0.4477%
================================================
Files 1322 1352 +30
Lines 396479 413182 +16703
================================================
+ Hits 290685 304781 +14096
- Misses 87265 89949 +2684
+ Partials 18529 18452 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
I forget to revert
tidbLogCfg.Level = "debug"
in #46726Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.