Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: fix a bug when reloading take a long time in domain.Init (#45170) #45389

Open
wants to merge 1 commit into
base: release-6.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45170

What problem does this PR solve?

Issue Number: close #45176

Problem Summary:
This problem should be that the load full schema takes 1min37s, that is, the lease period is exceeded, and there is no new load schema operation in the future. This error(Information schema is out of date) is reported when an SQL statement comes in.
Because the transaction will check the validity of the schema, and the validity check, if found txnTS bigger than schemaValidator.latestSchemaExpire, will quote this wrong.

What is changed and how it works?

Do a new reload to update schemaValidator.latestSchemaExpire, after the first reload in domain.Init.

In the future, we need to optimize the load schema operation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Case 1
Local cluster, 1 TiDB, 1 TiKV.
Make the first reload take 50s(do sleep in function) in domain.Init for master branch as test master.

Before this PR:
Upgrade from v6.5.2 to test master, failed to upgrade due to Information schema is out of date.
After this PR:
Upgrade from v6.5.2 to test master, successful to upgrade.

Case 2
Benchbot cluster, 1 TiDB, 3 TiKV.
Make the first reload take 54s(create 500,000 tables ) in domain.Init for master branch as test master.

Before this PR:
Upgrade from v6.5.2 to test master, failed to upgrade due to Information schema is out of date.
After this PR:
Upgrade from v6.5.2 to test master, successful to upgrade.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 17, 2023
@ti-chi-bot ti-chi-bot added the type/bugfix This PR fixes a bug. label Jul 17, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. label Jul 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 6, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 3492c6f link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 3492c6f link true /test check-dev2
idc-jenkins-ci-tidb/build 3492c6f link true /test build
idc-jenkins-ci-tidb/unit-test 3492c6f link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 3492c6f link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants