calibrate: refactor metrics error (#44451) #45167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
ti-chi-bot
added
release-note-none
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
size/XL
ti-chi-bot
added
the
cherry-pick-approved
17 tasks
This reverts commit 3736109. Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
|
and cherry-pick #43248 |
glorv
approved these changes
Jul 5, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
@nolouch PTAL |
nolouch
reviewed
Jul 5, 2023
| @@ -195,6 +196,11 @@ func (e *calibrateResourceExec) Next(ctx context.Context, req *chunk.Chunk) erro | |||
| return e.staticCalibrate(ctx, req, exec) | |||
| } | |||
|
|
|||
| var ( | |||
| errLowUsage = errors.Errorf("The workload in selected time window is too low, with which TiDB is unable to reach a capacity estimation; please select another time window with higher workload, or calibrate resource by hardware instead") | |||
There was a problem hiding this comment.
Suggested change
| errLowUsage = errors.Errorf("The workload in selected time window is too low, with which TiDB is unable to reach a capacity estimation; please select another time window with higher workload, or calibrate resource by hardware instead") | |
| errLowUsage = errors.Errorf("Unable to estimate capacity due to low workload in the selected time window. Please choose another time window with higher workload or calibrate hardware resources instead.") |
There was a problem hiding this comment.
This is a cherry-pick, it's not better to modify it.
nolouch
approved these changes
Jul 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44451
What problem does this PR solve?
Issue Number: ref #43212 close #45166
Problem Summary:
What is changed and how it works?
We attribute the case where metrics are empty and the case where there are too few metrics points available to the situation that the workload in selected time window is too low.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.