calibrate: refactor metrics error #44451
Conversation
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/M
executor/calibrate_resource.go
Outdated
| @@ -196,6 +196,11 @@ func (e *calibrateResourceExec) Next(ctx context.Context, req *chunk.Chunk) erro | |||
| return e.staticCalibrate(ctx, req, exec) | |||
| } | |||
|
|
|||
| var ( | |||
| errTooFewMetricsPoints = errors.Normalize("There are too few metrics points available in selected time window, %v") | |||
There was a problem hiding this comment.
Shall we also return the error message The workload in selected time window is too low ... here? The user may not know the meaning of too few metrics points
Signed-off-by: Cabinfever_B <[email protected]>
|
@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, HuSharp, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test check-dev |
glorv
added
the
needs-cherry-pick-release-7.1
|
In response to a cherrypick label: new pull request created to branch |
This reverts commit 3736109. Signed-off-by: Cabinfever_B <[email protected]>
What problem does this PR solve?
Issue Number: ref #43212 close #45166
Problem Summary:
What is changed and how it works?
We attribute the case where metrics are empty and the case where there are too few metrics points available to the situation that the workload in selected time window is too low.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.