statistics: remove h.mu.Lock when creating NewSessionStatsCollector (#44510) #44514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44510
What problem does this PR solve?
Issue Number: close #44502
Problem Summary:
What is changed and how it works?
We don't need to
h.mu.Lock
when creatingNewSessionStatsCollector
orNewSessionIndexUsageCollector
.Check List
Tests
Use
time.Sleep
to simulate slow internal sql indumpTableStatCountToKV
. WhendumpTableStatCountToKV
is holdingh.mu
, MySQL client can still establish connection with TiDB server.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.