Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: remove h.mu.Lock when creating NewSessionStatsCollector #44510

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Jun 8, 2023

What problem does this PR solve?

Issue Number: close #44502

Problem Summary:

What is changed and how it works?

We don't need to h.mu.Lock when creating NewSessionStatsCollector or NewSessionIndexUsageCollector.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Screenshot 2023-06-08 at 13 17 43

Use time.Sleep to simulate slow internal sql in dumpTableStatCountToKV. When dumpTableStatCountToKV is holding h.mu, MySQL client can still establish connection with TiDB server.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 8, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-08 05:22:43.765955 +0000 UTC m=+154855.610589591: ☑️ agreed by chrysan.
  • 2023-06-08 05:34:49.201164533 +0000 UTC m=+155581.045799133: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit ef1b724 into pingcap:master Jun 8, 2023
@chrysan chrysan added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44514.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44515.

@xuyifangreeneyes
Copy link
Contributor Author

/cherry-pick release-6.5-20230122-v6.5.0

@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: new pull request created to branch release-6.5-20230122-v6.5.0: #44533.

In response to this:

/cherry-pick release-6.5-20230122-v6.5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal sql related to stats block building new connection
4 participants