-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: remove h.mu.Lock when creating NewSessionStatsCollector #44510
Conversation
/check-issue-triage-complete |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrysan, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-6.5-20230122-v6.5.0 |
@xuyifangreeneyes: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #44502
Problem Summary:
What is changed and how it works?
We don't need to
h.mu.Lock
when creatingNewSessionStatsCollector
orNewSessionIndexUsageCollector
.Check List
Tests
Use
time.Sleep
to simulate slow internal sql indumpTableStatCountToKV
. WhendumpTableStatCountToKV
is holdingh.mu
, MySQL client can still establish connection with TiDB server.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.