Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: optimize the performance of GetParamSQLFromAST for non-prep plan cache #43161

Merged
merged 1 commit into from
Apr 18, 2023
Merged

planner: optimize the performance of GetParamSQLFromAST for non-prep plan cache #43161

merged 1 commit into from
Apr 18, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 18, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: optimize the performance of GetParamSQLFromAST for non-prep plan cache

What is changed and how it works?

planner: optimize the performance of GetParamSQLFromAST for non-prep plan cache

1.5X faster and 2X less allocs:

Before:
BenchmarkGetParamSQL-8            758413              1486 ns/op            2809 B/op         13 allocs/op

After:
BenchmarkGetParamSQL-8           1282550               927.4 ns/op           248 B/op          5 allocs/op

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9903198

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/merge

@qw4990 qw4990 mentioned this pull request Apr 18, 2023
Merged
12 tasks
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/test unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/merge

@ti-chi-bot ti-chi-bot merged commit c5cb7d2 into pingcap:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @ti-chi-bot @hawkingrei @xuyifangreeneyes