Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enable non-prep plan cache by default #43145

Merged
merged 6 commits into from
Apr 19, 2023
Merged

planner: enable non-prep plan cache by default #43145

merged 6 commits into from
Apr 19, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 18, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: enable non-prep plan cache by default

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner April 18, 2023 08:32
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ffca4d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023 •
edited
Loading

Wait for comp testing result.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

/hold

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2023

Wait for #43161

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 19, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 19, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 96d4286

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 19, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 19, 2023

/merge

@ti-chi-bot ti-chi-bot merged commit cd33faf into pingcap:master Apr 19, 2023
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-chi-bot @cfzjywxk @XuHuaiyu @time-and-fate