session: use TxnCtx.InfoSchema, no matter vars.InTxn() or not (#42027) #42279
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #42027
What problem does this PR solve?
Issue Number: close #41622 close #42003
Problem Summary:
What is changed and how it works?
Build plan need to use the same InfoSchema, but
vars.InTxn()
is false in #41622.Relax the condition can fix issue/41622
Alternative: change all
sctx.GetInfoSchema()
tosessiontxn.GetTxnManager(sctx).GetTxnInfoSchema()
It involves a lot of changes and seems more fragile comparing to this single line of change.
Check List
Tests
Test with the reproduce provided by @crazycs520 in the issue.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.