-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: use TxnCtx.InfoSchema, no matter vars.InTxn() or not #42027
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
/retest |
PTAL @lcwangchao @crazycs520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/test all |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: YangKeao <[email protected]>
What problem does this PR solve?
Issue Number: close #41622 close #42003
Problem Summary:
What is changed and how it works?
Build plan need to use the same InfoSchema, but
vars.InTxn()
is false in #41622.Relax the condition can fix issue/41622
Alternative: change all
sctx.GetInfoSchema()
tosessiontxn.GetTxnManager(sctx).GetTxnInfoSchema()
It involves a lot of changes and seems more fragile comparing to this single line of change.
Check List
Tests
Test with the reproduce provided by @crazycs520 in the issue.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.