-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: check redact when log compile error (#41832) #41921
session: check redact when log compile error (#41832) #41921
Conversation
Signed-off-by: lance6716 <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #41921 +/- ##
================================================
Coverage ? 73.6722%
================================================
Files ? 1083
Lines ? 347121
Branches ? 0
================================================
Hits ? 255732
Misses ? 74959
Partials ? 16430 |
/retest |
|
/retest |
This is an automated cherry-pick of #41832
What problem does this PR solve?
Issue Number: close #41831
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.