Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: check redact when log compile error #41832

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41831

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
[2023/03/01 20:14:09.452 +08:00] [WARN] [session.go:2208] ["compile SQL failed"] [conn=2199023255955] [error="[schema:1146]Table 'test.test' doesn't exist"] [SQL="load data infile ? into table `test` . `test`"]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2023
@lance6716
Copy link
Contributor Author

/cc @okJiang

@ti-chi-bot ti-chi-bot requested a review from okJiang March 1, 2023 12:16
@lance6716
Copy link
Contributor Author

/cc @crazycs520

@ti-chi-bot ti-chi-bot requested a review from crazycs520 March 1, 2023 12:17
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2023
@lance6716
Copy link
Contributor Author

/cc @Defined2014

@ti-chi-bot ti-chi-bot requested a review from Defined2014 March 3, 2023 07:51
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Mar 3, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2023
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae3f72c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2023
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2023
@Defined2014
Copy link
Contributor

/test mysql-test

@Defined2014
Copy link
Contributor

Defined2014 commented Mar 3, 2023

@lance6716 maybe need merge master to pass mysql-test

@lance6716
Copy link
Contributor Author

@lance6716 maybe need merge master to pass mysql-test

This PR already include #41823

*   bb9f786e1 (HEAD -> redact, origin/redact) Merge branch 'master' of github.com:pingcap/tidb into redact
|\
| * 227b461fe planner: optimize `ifnull(not-null-column, ...)` to a cast instead of eliminating it. tidb-test=pr/2098 (#41823)

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 5ba709f into pingcap:master Mar 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #41919.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #41920.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41921.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41922.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #41923.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41924.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #41925.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #41926.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41927.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 29, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"compile SQL failed" does not respect tidb_redact_log
4 participants