Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: introduce
ttl.PhysicalTable
to provide some common methods for TTL #39429ttl: introduce
ttl.PhysicalTable
to provide some common methods for TTL #39429Changes from all commits
99fec7c
2e254dd
1308eda
f7671bd
21ff8d1
34bb314
32f80d4
1e5c4ed
77505e1
da74f02
6a27b83
7c1f23a
6321317
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between
SELECT FROM_UNIXTIME(0) + INTERVAL %d SECOND - INTERVAL %s %s
andSELECT NOW() - INTERVAL %s %s
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference is that the
now
is an argument of the function for easy to mock in unit test andSELECT NOW() ...
is a hard code to use the real time