Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: introduce ttl.PhysicalTable to provide some common methods for TTL #39429

Merged
merged 13 commits into from
Nov 29, 2022
Merged

ttl: introduce ttl.PhysicalTable to provide some common methods for TTL #39429

merged 13 commits into from
Nov 29, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Nov 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39428

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2022
@lcwangchao lcwangchao changed the title ttl: introduce ttl.PhysicalTable to provide some common methods for… ttl: introduce ttl.PhysicalTable to provide some common methods for TTL Nov 28, 2022
@lcwangchao
Copy link
Collaborator Author

/run-all-tests

3 similar comments
@wuhuizuo
Copy link
Contributor

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

bb7133
bb7133 reviewed Nov 28, 2022
View reviewed changes
ttl/session.go Show resolved Hide resolved
ttl/table.go Outdated Show resolved Hide resolved
bb7133
bb7133 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ttl/session.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 29, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6321317

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
@hawkingrei
Copy link
Member

/run-unit-test

YangKeao
YangKeao approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little question 🤔

ttl/table.go
rows, err = se.ExecuteSQL(
ctx,
// FROM_UNIXTIME does not support negative value, so we use `FROM_UNIXTIME(0) + INTERVAL <current_ts>` to present current time
fmt.Sprintf("SELECT FROM_UNIXTIME(0) + INTERVAL %d SECOND - INTERVAL %s %s", now.Unix(), expireExpr, unit.String()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between SELECT FROM_UNIXTIME(0) + INTERVAL %d SECOND - INTERVAL %s %s and SELECT NOW() - INTERVAL %s %s?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that the now is an argument of the function for easy to mock in unit test and SELECT NOW() ... is a hard code to use the real time

@hawkingrei
Copy link
Member

/run-unit-test

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 1dd7a59 into pingcap:master Nov 29, 2022
@lcwangchao lcwangchao deleted the ttl_table branch November 29, 2022 07:32
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [3] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 9 min 11 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 2, success 26, total 28 7 min 20 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 7 min 5 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 36 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 31 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introduce ttl.PhysicalTable to provide some common methods for TTL
7 participants
@lcwangchao @ti-chi-bot @wuhuizuo @hawkingrei @sre-bot @bb7133 @YangKeao