-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: remove 1min no write check for unanalyzed table in auto analyze #39395
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2baec67
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #43355
Problem Summary:
What is changed and how it works?
Same as #39179
When we decide whether a table needs to be auto analzyzed, if the table has never been analyzed and there is no write to the table in the last minute, we trigger auto analyze for the table. The condition of no write in the last minute may prevent the table from auto analyze and the optimizer may choose wrong plans using pseudo stats. Hence the pr removes the condition. The condition of no write in the last minute was first introduced for the following case. When loading data, auto analyze v1 is triggered and preempts CPU and other resources with loading data. However, after auto analyze v2 is introduced, the resource consumption of analyze is reduced so it would not be a problem to trigger auto analyze when loading data.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.