ddl: Delete TiFlash sync status from etcd when table is truncated or dropped (#37184) #38268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Co-authored-by: Lynn <[email protected]>
Co-authored-by: Lynn <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
12 tasks
ti-chi-bot
added
size/M
VelocityLight
added
the
cherry-pick-approved
ti-chi-bot
requested review from
breezewish,
crazycs520,
lcwangchao and
zimulala
breezewish
approved these changes
Sep 30, 2022
VelocityLight
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
ti-chi-bot
added
the
needs-rebase
VelocityLight
added
cherry-pick-approved
xhebox
approved these changes
Oct 28, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
ti-chi-bot
removed
the
needs-rebase
|
This pull request has been accepted and is ready to merge. Commit hash: d58bf86
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #37184
Signed-off-by: CalvinNeo [email protected]
What problem does this PR solve?
Issue Number: close #37168
Problem Summary:
If a table with TiFlash replica is dropped of truncated, we have to delete its progress in etcd. Otherwise will cause too much obsolette keys in etcd if there are frequent dropping/truncating, which can lead to etcd oom.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.