Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Delete TiFlash sync status from etcd when table is truncated or dropped #37184

Merged
merged 14 commits into from
Sep 7, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 17, 2022

Signed-off-by: CalvinNeo [email protected]

What problem does this PR solve?

Issue Number: close #37168

Problem Summary:

If a table with TiFlash replica is dropped of truncated, we have to delete its progress in etcd. Otherwise will cause too much obsolette keys in etcd if there are frequent dropping/truncating, which can lead to etcd oom.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

f
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022

f
Signed-off-by: CalvinNeo <[email protected]>
f
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/cc @breezewish @crazycs520

f
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/cc @lcwangchao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #37675

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #37677

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #37678

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #37679

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37680

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #37681

@CalvinNeo
Copy link
Member Author

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@CalvinNeo: new pull request created: #38268.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/tiflash/table/sync not cleared
7 participants