-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: prevent generate error stack for BinaryLiteral.ToInt() (#37869) #37882
types: prevent generate error stack for BinaryLiteral.ToInt() (#37869) #37882
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: be55a27
|
cherry-pick #37869 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37882
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33494
Problem Summary:
For binary type error
ErrTruncatedWrongVal
, it is easy to locate. So it is not necessary to generate a stack for it.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.