Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high compile cpu when using long in list with varbinary type #33494

Closed
dbsid opened this issue Mar 28, 2022 · 2 comments · Fixed by #37869
Closed

high compile cpu when using long in list with varbinary type #33494

dbsid opened this issue Mar 28, 2022 · 2 comments · Fixed by #37869
Assignees
Labels
affects-5.3 This bug affects 5.3.x versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 sig/planner SIG: Planner type/performance

Comments

@dbsid
Copy link
Contributor

dbsid commented Mar 28, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

run a select statement with long in list with varbinary type

select * from t
where
`id` IN (...);

CREATE TABLE `t` (
  `id` varbinary(16) NOT NULL,
...

2. What did you expect to see? (Required)

fast compile

3. What did you see instead (Required)

long compile time

4. What is your TiDB version? (Required)

v5.3.1

AromG9Yakg

middle_img_v2_fdbdb5e3-7b78-4540-9ea3-233437aaa48g

@dbsid dbsid added the type/bug The issue is confirmed as a bug. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 labels Mar 28, 2022
@seiya-annie seiya-annie added the sig/execution SIG execution label Mar 28, 2022
@jebter jebter added the affects-5.3 This bug affects 5.3.x versions. label Apr 2, 2022
@ti-chi-bot ti-chi-bot removed the may-affects-5.3 This bug maybe affects 5.3.x versions. label Apr 2, 2022
@dbsid
Copy link
Contributor Author

dbsid commented Apr 24, 2022

The new pdqsort might help reduce the cpu on sort in this case.
https://news.ycombinator.com/item?id=31106157

@zanmato1984
Copy link
Contributor

This is more like a performance enhancement rather than a bug. Changing some labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.3 This bug affects 5.3.x versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 sig/planner SIG: Planner type/performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants