Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: handle nil store for plugins (#37321) #37322

Merged
merged 1 commit into from
Aug 23, 2022
Merged

session: handle nil store for plugins (#37321) #37322

merged 1 commit into from
Aug 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 23, 2022 •
edited
Loading

cherry-pick #37321 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37322

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/37322:release-6.1-3a4e3eab83e8

Signed-off-by: xhe [email protected]

What problem does this PR solve?

Issue Number: close #37319

Problem Summary: Enterprise plugin will pass nil store.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix panic of enterprise plugin on 6.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.1-cherry-pick labels Aug 23, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 23, 2022
Merged
12 tasks
@ti-srebot ti-srebot added this to the v6.1.1 milestone Aug 23, 2022
@ti-srebot
Copy link
Contributor Author

@xhebox you're already a collaborator in bot's repo.

bb7133
bb7133 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/77fdf88b9019aff0140940bbde2be9dbb3998554

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 23, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77fdf88

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@ti-chi-bot ti-chi-bot merged commit 08ed961 into pingcap:release-6.1 Aug 23, 2022
@hawkingrei hawkingrei deleted the release-6.1-3a4e3eab83e8 branch August 23, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@winoros winoros Awaiting requested review from winoros

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@yudongusa yudongusa Awaiting requested review from yudongusa

Assignees

@xhebox xhebox

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @sre-bot @xhebox @bb7133 @hawkingrei