Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: handle nil store for plugins #37321

Merged
merged 2 commits into from
Aug 23, 2022
Merged

session: handle nil store for plugins #37321

merged 2 commits into from
Aug 23, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 23, 2022

Signed-off-by: xhe [email protected]

What problem does this PR solve?

Issue Number: close #37319

Problem Summary: Enterprise plugin will pass nil store.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix panic of enterprise plugin on 6.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2022
@xhebox xhebox mentioned this pull request Aug 23, 2022
Closed
@xhebox xhebox requested review from wjhuang2016 and bb7133 August 23, 2022 13:54
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3bb78c3a5a8bcda98ef3b8920d8c966f7817d155

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Aug 23, 2022
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

bb7133
bb7133 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
@ti-chi-bot
Copy link
Member

@yudongusa: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yudongusa
Copy link

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2022
@hawkingrei
Copy link
Member

/merge

1 similar comment
@xhebox
Copy link
Contributor Author

xhebox commented Aug 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 920b416

1 similar comment
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 920b416

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2022

/merge

@xhebox
Copy link
Contributor Author

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

@ti-chi-bot ti-chi-bot merged commit 3a4e3ea into pingcap:master Aug 23, 2022
@xhebox xhebox deleted the store branch August 23, 2022 15:40
@ti-srebot ti-srebot mentioned this pull request Aug 23, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 23, 2022
@xhebox @ti-srebot
cherry pick pingcap#37321 to release-6.1
77fdf88 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37322

ti-chi-bot pushed a commit that referenced this pull request Aug 23, 2022
@ti-srebot
session: handle nil store for plugins (#37321) (#37322)
08ed961 
close #37319
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 7, success 10, total 17 14 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 38 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 56 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 17 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yudongusa yudongusa yudongusa approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not start tidb-server while using plugin
8 participants
@xhebox @ti-chi-bot @sre-bot @bb7133 @yudongusa @hawkingrei @ti-srebot @xiongjiwei