Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessiontxn/isolation: fix goleak for TestPessimisticRCTxnContextProviderRCCheckForPrepareExecute #36242

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36212

Problem Summary:

What is changed and how it works?

Even session.ResultSetToStringSlice(ctx, tk.Session(), rs) return error, the rs should be closed.
Otherwise the will be resource (goroutine) leak.

Check List

Tests

  • Unit test

go test -v -run TestPessimisticRCTxnContextProviderRCCheckForPrepareExecute

--- PASS: TestPessimisticRCTxnContextProviderRCCheckForPrepareExecute (0.11s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 321 in state select, with github.com/pingcap/tidb/store/copr.(*copIteratorWorker).sendToRespCh on top of the stack:
goroutine 321 [select]:
github.com/pingcap/tidb/store/copr.(*copIteratorWorker).sendToRespCh(0xc00561dc70?, 0x43dfd78?, 0xc0053a0180?, 0x14?)
	/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:542 +0xad
github.com/pingcap/tidb/store/copr.(*copIteratorWorker).run(0xc00561dc70, {0x43dfd78, 0xc0053a0180})
	/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:409 +0xe5
created by github.com/pingcap/tidb/store/copr.(*copIterator).open
	/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:437 +0x78

 Goroutine 450 in state semacquire, with sync.runtime_Semacquire on top of the stack:
goroutine 450 [semacquire]:
sync.runtime_Semacquire(0xc000c3d750?)
	/home/genius/project/go/src/runtime/sema.go:56 +0x25
sync.(*WaitGroup).Wait(0xc0052aef00?)
	/home/genius/project/go/src/sync/waitgroup.go:136 +0x52
github.com/pingcap/tidb/store/copr.(*copIteratorTaskSender).run(0xc004b9ce40)
	/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:477 +0xb3
created by github.com/pingcap/tidb/store/copr.(*copIterator).open
	/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:454 +0x385
]
exit status 1
FAIL	github.com/pingcap/tidb/sessiontxn/isolation	0.585s
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review July 15, 2022 09:16
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei hawkingrei added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 15, 2022
@hawkingrei
Copy link
Member

/lgtm

@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022

@hawkingrei hawkingrei self-requested a review July 15, 2022 09:32
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@tiancaiamao: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bd2f740

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 1 min 14 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goleak in the sessiontxn/isolation
6 participants