-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: use non-buffered channel for coprocessor response #35988
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Also close #34849 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 11068ad
|
/run-unit-test |
/run-all-tests |
/run-unit-test |
/run-mysql-test |
/run-unit-test |
/run-unit-test |
/run-check_dev_2 |
/run-unit-test |
/hold |
/unhold After #36242 it should work now. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5140c8d3dba4f559834c51b62bfd7d0e77551abd |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #35987
Problem Summary:
What is changed and how it works?
DistSQL concurrency default value is 16, there are so many workers already.
If we use a buffered channel for the tasks, there will be a lot of data cached in TiDB, consuming a lot of memory.
Change the buffered channel to a non-buffered channel, to reduce the memory footprint.
Note, this change does not make performance regression!
Before
After
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.