-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/mockstore/unistore: fix several issues of coprocessor paging in unistore #36147
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ab2fe819269b8d6c95e3192b416e3b7481fe8fd5 |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4a3a584
|
/run-build |
/run-build |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
* master: (27 commits) executor: parallel cancel mpp query (pingcap#36161) store/copr: adjust the cop cache admission process time for paging (pingcap#36157) log-backup: get can restored global-checkpoint-ts when support v3 checkpoint advance (pingcap#36197) executor: optimize cursor read point get by reading through pessimistic lock cache (pingcap#36149) *: add tidb_min_paging_size system variable (pingcap#36107) planner: handle the expected row count for pushed-down selection in mpp (pingcap#36195) *: support show ddl jobs for sub-jobs (pingcap#36168) table-filter: optimize table pattern message and unit tests (pingcap#36160) domain: fix unstable test TestAbnormalSessionPool (pingcap#36154) executor: check the error returned by `handleNoDelay` (pingcap#36105) log-backup: fix checkpoint display (pingcap#36166) store/mockstore/unistore: fix several issues of coprocessor paging in unistore (pingcap#36147) test: refactor restart test (pingcap#36174) ddl: support rename index and columns for multi-schema change (pingcap#36148) test: remove meaningless test and update bazel (pingcap#36136) planner: Reduce verbosity of logging unknown system variables (pingcap#36013) metrics/grafana: bring back the plan cache miss panel (pingcap#36081) ddl: implement table granularity DDL for SchemaTracker (pingcap#36077) *: bazel use jdk 17 (pingcap#36070) telemetry: add reviewer rule (pingcap#36084) ...
What problem does this PR solve?
Issue Number: close #36145
Problem Summary:
What is changed and how it works?
Fix several bugs.
break
... which should bereturn
key/value
in a iterator function, deep copy should be usedTake this as example:
CopDAG: TopN -> IndexScan
IndexScan rows = 1000
TopN count = 400
Paging size = 64
If TopN calculate the top 400, it consume the whole IndexScan rows ...
it returns 64 rows, but it can't determine the corresponding key range!
Check List
Tests
I found the bug when testing #36107
When @@tidb_min_paging_size is set, the current unit tests could cover the change.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.