Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_variables: remove the limitation for set tidb_gc_life_time (#35411) #35467

Merged
merged 1 commit into from
Jun 21, 2022
Merged

system_variables: remove the limitation for set tidb_gc_life_time (#35411) #35467

merged 1 commit into from
Jun 21, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 17, 2022 •
edited
Loading

cherry-pick #35411 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35467

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/35467:release-6.1-081bd10d5472

Signed-off-by: TonsnakeLin [email protected]

What problem does this PR solve?

Issue Number: close #35392

Problem Summary:

What is changed and how it works?

Remove the check work when set variable tidb_gc_life_time

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-srebot ti-srebot requested a review from a team as a code owner June 17, 2022 05:43
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 17, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 17, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
@ti-srebot
Copy link
Contributor Author

@TonsnakeLin please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a53bee4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 17, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a53bee496085cce941baf679749e57ee1d8817b0

@TonsnakeLin
Copy link
Contributor

/run-check_dev

@TonsnakeLin
Copy link
Contributor

/run-unit-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 21, 2022
@ti-chi-bot ti-chi-bot merged commit 40f19cb into pingcap:release-6.1 Jun 21, 2022
@cfzjywxk
Copy link
Contributor

/merge

@purelind purelind added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@sticnarf sticnarf Awaiting requested review from sticnarf

Assignees

@TonsnakeLin TonsnakeLin

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @cfzjywxk @sre-bot @TonsnakeLin @ekexium @VelocityLight @purelind