Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_variables: remove the limitation for set tidb_gc_life_time #35411

Merged
merged 6 commits into from
Jun 16, 2022
Merged

system_variables: remove the limitation for set tidb_gc_life_time #35411

merged 6 commits into from
Jun 16, 2022

Conversation

TonsnakeLin
Copy link
Contributor

@TonsnakeLin TonsnakeLin commented Jun 15, 2022 •
edited
Loading

Signed-off-by: TonsnakeLin [email protected]

What problem does this PR solve?

Issue Number: close #35392

Problem Summary:

What is changed and how it works?

Remove the check work when set variable tidb_gc_life_time

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@TonsnakeLin TonsnakeLin requested a review from a team as a code owner June 15, 2022 13:08
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jun 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1335c7c222216041ce84e74f3314b4554f6fa5f0

@TonsnakeLin
Copy link
Contributor Author

/cc @cfzjywxk @sticnarf @ekexium

@TonsnakeLin
Copy link
Contributor Author

/run-realtikv-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2022
@cfzjywxk
Copy link
Contributor

We may need to file an issue to change the variable unit of tidb_max_gc_wait_time to the same as tidb_gc_life_time in the future. But may this introduce another compatibility issue if tidb_max_gc_wait_time is used?

sticnarf
sticnarf approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests for it later

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2022
@TonsnakeLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@TonsnakeLin: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4d8b56d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@ti-chi-bot ti-chi-bot merged commit 081bd10 into pingcap:master Jun 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 10, total 11 23 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 21 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 1 hr 10 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 38 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 8 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 36 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@jebter
Copy link

jebter commented Jun 17, 2022

/label needs-cherry-pick-6.1

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 17, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@TonsnakeLin @ti-srebot
cherry pick pingcap#35411 to release-6.1
a53bee4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35467

ti-chi-bot pushed a commit that referenced this pull request Jun 21, 2022
@ti-srebot
system_variables: remove the limitation for set tidb_gc_life_time (#3…
40f19cb 
…5411) (#35467)

close #35392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR 1231 (42000): Variable 'tidb_gc_life_time' can't be set to the value of '72h0m0s'
8 participants
@TonsnakeLin @ti-chi-bot @sre-bot @cfzjywxk @jebter @ti-srebot @sticnarf @hawkingrei