Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: skip the transaction start_ts used by analyze calculating the gc #35210

Merged
merged 2 commits into from
Jun 10, 2022
Merged

txn: skip the transaction start_ts used by analyze calculating the gc #35210

merged 2 commits into from
Jun 10, 2022

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Jun 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35062

Problem Summary:

Back pick #35144 to the master branch as it's urgent to fix the issue
on the release-6.1 branch. This is a workaround solution, it's still needed to solve it completely in the
next release.

What is changed and how it works?

Check List

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@cfzjywxk cfzjywxk added type/bugfix This PR fixes a bug. sig/transaction SIG:Transaction labels Jun 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
@cfzjywxk cfzjywxk removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/181e59c5d748eba0e7822b0440f1056607304bf1

@cfzjywxk cfzjywxk changed the title txn: skip the transaction start_ts used by analyze calculating the gc… txn: skip the transaction start_ts used by analyze calculating the gc Jun 7, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 7, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2022
TonsnakeLin
TonsnakeLin approved these changes Jun 10, 2022
View reviewed changes
session/session.go
}
processInfo := tmp.ShowProcess()
if processInfo != nil {
processInfoID = processInfo.ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get session id from tmp.sessionvars.id
the rest LGTM

Copy link
Contributor Author

@cfzjywxk cfzjywxk Jun 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safer to distinguish the processid and sessionid, comparing the processid explicitly avoids the implicit constraint that they must be the same as the analyze process injects the processid at the start.
Anyway, this is a temporary solution and could be removed after the decoupling of analyze worker and garbage collection.

@ti-chi-bot
Copy link
Member

@TonsnakeLin: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@cfzjywxk: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk cfzjywxk removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2022
@cfzjywxk
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: acb92f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 10, 2022
@cfzjywxk cfzjywxk removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 10, 2022
@ti-chi-bot ti-chi-bot merged commit 58ceefc into pingcap:master Jun 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 7 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 50 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 41 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@chrysan chrysan Awaiting requested review from chrysan

@you06 you06 Awaiting requested review from you06

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long auto-analyze txn blocks GC
6 participants
@cfzjywxk @ti-chi-bot @sre-bot @MyonKeminta @xuyifangreeneyes @TonsnakeLin