Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: skip the transaction start_ts used by analyze calculating the gc safepoint #35144

Merged
merged 1 commit into from
Jun 5, 2022
Merged

txn: skip the transaction start_ts used by analyze calculating the gc safepoint #35144

merged 1 commit into from
Jun 5, 2022

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Jun 4, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Try do skip the transaction start_ts used by analyze calculating the GC safepoint, so the GC process would not be blocked.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Slow donw the analyzeExec
    • Print the calculated safepoint
    • Check if the safepoint is moving forward as expected.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@cfzjywxk cfzjywxk requested review from chrysan, you06 and TonsnakeLin June 4, 2022 03:03
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2022
chrysan
chrysan approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@chrysan chrysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2022
TonsnakeLin
TonsnakeLin reviewed Jun 4, 2022
View reviewed changes
session/session.go
return 0
return 0, 0
}
processInfo := tmp.ShowProcess()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get the id from "tmp.sessionVars.ConnectionID"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the analyze identifier is injected using ProcessID perhaps it's safer to use ProcessID to do the comparison.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoAnalyzeProcID is assigned to session.GetSessionVars().ConnectionID and then session.processInfo.ID is set to session.GetSessionVars().ConnectionID.

@dbsid
Copy link
Contributor

dbsid commented Jun 4, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/ece8c90f40233d2dc5227237129d630ceeaa1664/centos7/tidb-linux-arm64.tar.gz

@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ece8c90f40233d2dc5227237129d630ceeaa1664

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 5, 2022
@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Jun 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ece8c90

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2022
@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Jun 5, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 1a89dec into pingcap:release-6.1 Jun 5, 2022
cfzjywxk added a commit to cfzjywxk/tidb that referenced this pull request Jun 7, 2022
@cfzjywxk
txn: skip the transaction start_ts used by analyze calculating the gc…
acb92f9 
… safepoint (pingcap#35144)
@cfzjywxk cfzjywxk mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonsnakeLin TonsnakeLin TonsnakeLin left review comments

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@you06 you06 you06 approved these changes

@chrysan chrysan chrysan approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cfzjywxk @ti-chi-bot @dbsid @sre-bot @chrysan @you06 @xuyifangreeneyes @TonsnakeLin