Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix tables_priv table schema(33599) #33600

Merged
merged 1 commit into from
Mar 30, 2022
Merged

session: fix tables_priv table schema(33599) #33600

merged 1 commit into from
Mar 30, 2022

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 30, 2022 •
edited
Loading

cherry-pick #33599

What problem does this PR solve?

Issue Number: close #33588

Problem Summary:

#28546 modify tables_priv and columns_priv tables' column(Column_priv) type. But it doesn't update tables_priv column in upgrade step.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    deploy a v5.2 cluster
    upgrade to this PR.
    execute SQL
use test;
create table t(a int);
create user u1;
grant all on test.t to u1;
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

 Fix the issue that privilege-related operations may fail for upgraded clusters.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@zimulala zimulala requested a review from a team as a code owner March 30, 2022 12:49
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2022
@zimulala zimulala changed the title session: fix tables_priv table schema() session: fix tables_priv table schema(33599) Mar 30, 2022
bb7133
bb7133 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2022
@bb7133
Copy link
Member

bb7133 commented Mar 30, 2022

For the release note, how about:

 Fix the issue that privilege-related operations may fail for upgraded clusters.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 30, 2022
@bb7133
Copy link
Member

bb7133 commented Mar 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 62e7e7c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@zimulala
Copy link
Contributor Author

/run-mysql-test
/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Mar 30, 2022

/merge

@zimulala
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/62e7e7cc41e665efb36c8ca1834694fa27411f0f

@zimulala
Copy link
Contributor Author

/run-mysql-test
/run-unit-test

@zimulala
Copy link
Contributor Author

/run-mysql-test

4 similar comments
@zimulala
Copy link
Contributor Author

/run-mysql-test

@zimulala
Copy link
Contributor Author

/run-mysql-test

@zimulala
Copy link
Contributor Author

/run-mysql-test

@zimulala
Copy link
Contributor Author

/run-mysql-test

@zimulala zimulala mentioned this pull request Mar 30, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot merged commit 238f79b into pingcap:release-6.0 Mar 30, 2022
@zimulala zimulala deleted the zimuxia/priv-6 branch March 30, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zimulala @ti-chi-bot @bb7133 @sre-bot @Defined2014 @zhouqiang-cl