Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: support references on column #28546

Merged
merged 4 commits into from
Oct 7, 2021
Merged

session: support references on column #28546

merged 4 commits into from
Oct 7, 2021

Conversation

unconsolable
Copy link
Contributor

Signed-off-by: unconsolable [email protected]

What problem does this PR solve?

Issue Number: close #28531

What is changed and how it works?

What's Changed:

  • Add ReferencesPriv in AllColumnPrivs in parser
  • Change CreateTablePrivTable and CreateColumnPrivTable SQL statements in session/bootstrap.go

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support references privilege on column level.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TszKitLo40
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
@unconsolable
session: add bootstrap task
dec0726 
Signed-off-by: unconsolable <[email protected]>
@unconsolable
*: add changes in 28547
74a54da 
Signed-off-by: unconsolable <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2021
@TszKitLo40 TszKitLo40 mentioned this pull request Oct 4, 2021
Merged
12 tasks
@unconsolable unconsolable requested a review from morgo October 6, 2021 15:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 6, 2021
TszKitLo40
TszKitLo40 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@TszKitLo40 TszKitLo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 7, 2021
@unconsolable
Copy link
Contributor Author

/assign @morgo
Could you please help on merging?

@morgo
Copy link
Contributor

morgo commented Oct 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e05e5e4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 7, 2021
@ti-chi-bot ti-chi-bot merged commit 6eb02fb into pingcap:master Oct 7, 2021
@unconsolable unconsolable deleted the issue-28531 branch October 7, 2021 06:16
@unconsolable unconsolable mentioned this pull request Nov 5, 2021
Closed
This was referenced Mar 30, 2022
Merged
Merged
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Merged
12 tasks
This was referenced Mar 30, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TszKitLo40 TszKitLo40 TszKitLo40 approved these changes

@morgo morgo morgo approved these changes

Assignees

@morgo morgo

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

References privilege should be column-level
4 participants
@unconsolable @ti-chi-bot @morgo @TszKitLo40