Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: migrate tidb-tools #33296

Merged
merged 28 commits into from
Mar 25, 2022
Merged

*: migrate tidb-tools #33296

merged 28 commits into from
Mar 25, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 21, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32999

Problem Summary:

What is changed and how it works?

migrate tidb-tools into tidb and remove tidb-tool dependency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hawkingrei hawkingrei requested a review from a team as a code owner March 21, 2022 16:10
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eed32dd3cecdd70fa40990ae3e0dd5c8a9831ae8

@hawkingrei
migrate util
41dea0b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate cpu
7d3f3a3 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate dbutil
6e08b40 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate error
d9ce997 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate processinfo
f375446 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate urls
3a28243 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate tso
29548f3 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate tls_test
e02c90a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate table-rule-selector
30c0bbd 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate table-router
d65d7f2 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate table-filter
2b75e33 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate security
82b5a58 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate schemacmp
679eee0 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate regexpr-router
e759a48 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate etcd
57f93b2 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate filter
c5e937e 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate printer
50dc09b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
migrate tidb-binlog
e1fb237 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
remove tidb-tools
dc5edcb 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
remove tidb-tools
9be1af1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update gomod
5962c8e 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update chore
92ddc79 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update chore
aa913f6 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-mysql-test

BornChanger
BornChanger approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 82a653b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@lance6716
Copy link
Contributor

/run-unit-tests

@hawkingrei
Copy link
Member Author

/run-check_dev_2
/run-mysql-test
/run-unit-test

@ti-chi-bot
Copy link
Member

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/run-unit-tes
/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 6517ee3 into pingcap:master Mar 25, 2022
@hawkingrei hawkingrei deleted the migrate_tidb_tools branch March 25, 2022 11:15
This was referenced Mar 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@lance6716 lance6716 lance6716 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@BornChanger BornChanger BornChanger approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate tidb-tools into tidb
7 participants
@hawkingrei @ti-chi-bot @sre-bot @lance6716 @kennytm @cfzjywxk @BornChanger