Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: migrate tidb-tools #32996

Closed
wants to merge 2 commits into from
Closed

*: migrate tidb-tools #32996

wants to merge 2 commits into from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 10, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #32999

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/38592a5790717b2bcea50d0656b881604153b53e

@hawkingrei hawkingrei force-pushed the mrigate_tidb_tools branch 2 times, most recently from 5bdd71e to 7d6d0d3 Compare March 11, 2022 02:57
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2022
@hawkingrei hawkingrei force-pushed the mrigate_tidb_tools branch 2 times, most recently from ae8806d to d76e7bc Compare March 12, 2022 14:18
@hawkingrei hawkingrei requested a review from a team as a code owner March 12, 2022 14:33
@hawkingrei hawkingrei force-pushed the mrigate_tidb_tools branch 2 times, most recently from 74ea5b9 to 56af6be Compare March 13, 2022 12:44
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@disksing
Copy link
Contributor

maybe we should replace testify in tidb-tools repo and merge to here later.

BornChanger
BornChanger reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the failure of idc-jenkins-ci-tidb/check_dev, which seems to be improper comments.

@hawkingrei hawkingrei changed the title *: migrate table-filter of tidb-tools *: migrate tidb-tools Mar 17, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2022
@hawkingrei hawkingrei force-pushed the mrigate_tidb_tools branch 6 times, most recently from 7a0bc3c to a86144c Compare March 21, 2022 06:46
@hawkingrei
make linter happy
38592a5 
Signed-off-by: Weizhen Wang <[email protected]>
@tisonkun
Copy link
Contributor

@hawkingrei shall this be closed according to #33296?

@lance6716
Copy link
Contributor

@hawkingrei shall this be closed according to #33296?

ping @hawkingrei

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@ti-chi-bot
Copy link
Member

@hawkingrei: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei hawkingrei closed this Mar 30, 2022
@hawkingrei hawkingrei deleted the mrigate_tidb_tools branch March 30, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger left review comments

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate tidb-tools into tidb
7 participants
@hawkingrei @ti-chi-bot @sre-bot @disksing @tisonkun @lance6716 @BornChanger