-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: migrate tidb-tools #32996
*: migrate tidb-tools #32996
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/38592a5790717b2bcea50d0656b881604153b53e |
5bdd71e
to
7d6d0d3
Compare
ae8806d
to
d76e7bc
Compare
74ea5b9
to
56af6be
Compare
/run-unit-test |
maybe we should replace testify in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the failure of idc-jenkins-ci-tidb/check_dev, which seems to be improper comments.
1713ade
to
c59907c
Compare
7a0bc3c
to
a86144c
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
a86144c
to
38592a5
Compare
@hawkingrei shall this be closed according to #33296? |
ping @hawkingrei |
@hawkingrei: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Weizhen Wang [email protected]
What problem does this PR solve?
Issue Number: close #32999
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note