Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: use prepare text to build the plan cache key for reuse #31520

Closed
wants to merge 9 commits into from
Closed

planner: use prepare text to build the plan cache key for reuse #31520

wants to merge 9 commits into from

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Jan 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #31056

Problem Summary:
use prepare text to build the plan cache key for reuse

What is changed and how it works?

use prepare text to build the plan cache key for reuse

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jan 10, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2022
@Reminiscent Reminiscent changed the title planner: use stmtText to build the plan cache key for reuse planner: use prepare text to build the plan cache key for reuse Jan 10, 2022
@Reminiscent
Copy link
Contributor Author

/run-build-arm64 comment=true

@Reminiscent
Copy link
Contributor Author

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Jan 10, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/f1a4f8f2eaefd6dfbc3687017b44b5dbe5d39bee/centos7/tidb-linux-arm64.tar.gz

@shaoxiqian
Copy link
Contributor

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jan 10, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/7fff6e349503baef91b00042f2f338356562a340/centos7/tidb-linux-arm64.tar.gz

@qw4990 qw4990 requested review from qw4990 and rebelice January 11, 2022 02:48
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@Reminiscent
Copy link
Contributor Author

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jan 12, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/34dd43fdbafee38389a27d708e337713db2efdb0/centos7/tidb-linux-arm64.tar.gz

@ti-chi-bot
Copy link
Member

@Reminiscent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved epic/plan-cache needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reminiscent @ti-chi-bot @sre-bot @shaoxiqian @qw4990