Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use normalSQL to build the plan cache key #31441

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Jan 7, 2022

What problem does this PR solve?

Issue Number: close #31056

Problem Summary:
We do not clean the plan cache when execute stmt.close.

What is changed and how it works?

Use normalSQL to build the plan cache key

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    @dbsid Use the internal test cases to verify this PR.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner epic/plan-cache labels Jan 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2022
@dbsid
Copy link
Contributor

dbsid commented Jan 7, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

@Reminiscent
Copy link
Contributor Author

/run-check_dev

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 7, 2022
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member

@VelocityLight: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2022
@zhouqiang-cl zhouqiang-cl merged commit 305ced4 into pingcap:release-5.3-20220107 Jan 7, 2022
@Reminiscent Reminiscent deleted the 31056 branch January 7, 2022 08:09
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants