-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: added pre-commit hook. #3112
Changes from 1 commit
48dcea6
9b3d99e
14dbbf8
92af871
ff685a0
d73c4c3
d305cb4
705cc99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,9 +24,9 @@ LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev- | |
|
||
TARGET = "" | ||
|
||
.PHONY: all build update parser clean todo test gotest interpreter server dev benchkv benchraw check parserlib | ||
.PHONY: all build update parser clean todo test gotest interpreter server dev benchkv benchraw check parserlib precommithook | ||
|
||
default: server buildsucc | ||
default: server buildsucc precommithook | ||
|
||
buildsucc: | ||
@echo Build TiDB Server successfully! | ||
|
@@ -140,3 +140,7 @@ endif | |
glide vc --only-code --no-tests | ||
mkdir -p _vendor | ||
mv vendor _vendor/src | ||
|
||
precommithook: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As comments are added in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One time job should not be added to Makefile. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DONE |
||
ln -s hooks/pre-commit .git/hooks/ | ||
chmod +x .git/hooks/pre-commit |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ import ( | |
|
||
// extractCorColumnsBySchema only extracts the correlated columns that match the outer plan's schema. | ||
// e.g. If the correlated columns from inner plan are [t1.a, t2.a, t3.a] and outer plan's schema is [t2.a, t2.b, t2.c], | ||
// only [t2.a] is treated as this apply's correlated column. | ||
// only [t2.a] is treated as this applies correlated column. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is unrelated change. |
||
func (a *LogicalApply) extractCorColumnsBySchema() { | ||
schema := a.children[0].Schema() | ||
corCols := a.children[1].(LogicalPlan).extractCorrelatedCols() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not add it in default.