*: added pre-commit hook. #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea! |
|
@coocood Yes. It comes from K8s. I will add credits later. |
zhexuany
force-pushed
the
added_pre_commit_hook
branch
from
0757b8e to
591b272
Compare
|
LGTM |
zhexuany
force-pushed
the
added_pre_commit_hook
branch
2 times, most recently
from
591b272 to
7d03940
Compare
|
LGTM |
hanfei1991
reviewed
Apr 23, 2017
|
|
||
| echo -ne "Checking for files that need goword... " | ||
| files_need_goword=() | ||
| files=($(git diff --cached --name-only --diff-filter ACM | grep "\.go" | grep -v -e "^_vendor")) |
There was a problem hiding this comment.
@hanfei1991 https://git-scm.com/docs/git-diff#git-diff---diff-filterACDMRTUXB82308203
--diff-filter=[(A|C|D|M|R|T|U|X|B)…[*]]
Select only files that are Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R), have their type (i.e. regular file, symlink, submodule, …) changed (T), are Unmerged (U), are Unknown (X), or have had their pairing Broken (B). Any combination of the filter characters (including none) can be used. When * (All-or-none) is added to the combination, all paths are selected if there is any file that matches other criteria in the comparison; if there is no file that matches other criteria, nothing is selected.
Also, these upper-case letters can be downcased to exclude. E.g. --diff-filter=ad excludes added and deleted paths.
e60560e to
b0e26a5
Compare
|
@shenli PTAL |
zhexuany
force-pushed
the
added_pre_commit_hook
branch
from
bde2344 to
9b3d99e
Compare
coocood
reviewed
Apr 24, 2017
Makefile
Outdated
|
|
||
| default: server buildsucc | ||
| default: server buildsucc precommithook |
There was a problem hiding this comment.
Please do not add it in default.
coocood
reviewed
Apr 24, 2017
plan/decorrelate.go
Outdated
| @@ -23,7 +23,7 @@ import ( | |||
|
|
|||
| // extractCorColumnsBySchema only extracts the correlated columns that match the outer plan's schema. | |||
| // e.g. If the correlated columns from inner plan are [t1.a, t2.a, t3.a] and outer plan's schema is [t2.a, t2.b, t2.c], | |||
| // only [t2.a] is treated as this apply's correlated column. | |||
| // only [t2.a] is treated as this applies correlated column. | |||
coocood
reviewed
Apr 24, 2017
Makefile
Outdated
| @@ -140,3 +140,7 @@ endif | |||
| glide vc --only-code --no-tests | |||
| mkdir -p _vendor | |||
| mv vendor _vendor/src | |||
|
|
|||
| precommithook: | |||
There was a problem hiding this comment.
As comments are added in the pre-commit file, this is redundant.
There was a problem hiding this comment.
One time job should not be added to Makefile.
coocood
reviewed
Apr 24, 2017
hooks/pre-commit
Outdated
| files_need_goword=() | ||
| files=($(git diff --cached --name-only --diff-filter ACM | grep "\.go" | grep -v -e "^_vendor")) | ||
| for file in "${files[@]}"; do | ||
| # Check for files that fail gofmt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, future commited code has to satisfy the rule we specify in
pre-commit.