planner: add warnings about joins when tidb_enforce_mpp is enabled. (#26246) #26272

ti-srebot · 2021-07-15T08:23:02Z

cherry-pick #26246 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26272

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/26272:release-5.1-76c5fd0e26b1

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1905

Problem Summary: This is the follow-up of #25302, add warnings when tidb_enforce_mpp is enabled but mpp is blocked.

What is changed and how it works?

What's Changed: adding warnings for join.

How it Works:

Check List

Tests

Unit test
Integration test

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

No release note

Signed-off-by: ti-srebot <[email protected]>

ti-srebot · 2021-07-15T08:23:05Z

/run-all-tests

ti-srebot · 2021-07-15T08:23:10Z

@LittleFall you're already a collaborator in bot's repo.

LittleFall · 2021-07-21T12:06:33Z

2021-07-21T11:43:38.287Z]
[2021-07-21T11:43:38.287Z] ----------------------------------------------------------------------
[2021-07-21T11:43:38.287Z] FAIL: analyze_test.go:934: testSerialSuite2.TestIssue20874
[2021-07-21T11:43:38.287Z]
[2021-07-21T11:43:38.287Z] analyze_test.go:964:
[2021-07-21T11:43:38.287Z] tk.MustQuery("show stats_topn where db_name = 'test' and table_name = 't'").Sort().Check(testkit.Rows(
[2021-07-21T11:43:38.287Z] "test t a 0 \x02\xd2 1",
[2021-07-21T11:43:38.287Z] "test t a 0 \x0e\x0f 1",
[2021-07-21T11:43:38.287Z] "test t a 0 \x0e3 1",
[2021-07-21T11:43:38.287Z] "test t b 0 \x00A 1",
[2021-07-21T11:43:38.287Z] "test t b 0 \x00C 2",
[2021-07-21T11:43:38.287Z] "test t idxa 1 \x02\xd2 1",
[2021-07-21T11:43:38.287Z] "test t idxa 1 \x0e\x0f 1",
[2021-07-21T11:43:38.287Z] "test t idxa 1 \x0e3 1",
[2021-07-21T11:43:38.287Z] "test t idxb 1 \x00A 1",
[2021-07-21T11:43:38.287Z] "test t idxb 1 \x00C 2",
[2021-07-21T11:43:38.287Z] ))
[2021-07-21T11:43:38.287Z] /home/jenkins/agent/workspace/tidb_ghpr_check/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:63:
[2021-07-21T11:43:38.287Z] res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
[2021-07-21T11:43:38.287Z] ... obtained string = "[test t b 0 \x00C 2]\n"
[2021-07-21T11:43:38.287Z] ... expected string = "" +
[2021-07-21T11:43:38.287Z] ... "[test t a 0 \x02\xd2 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t a 0 \x0e\x0f 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t a 0 \x0e3 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t b 0 \x00A 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t b 0 \x00C 2]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t idxa 1 \x02\xd2 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t idxa 1 \x0e\x0f 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t idxa 1 \x0e3 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t idxb 1 \x00A 1]\n" +
[2021-07-21T11:43:38.287Z] ... "[test t idxb 1 \x00C 2]\n"
[2021-07-21T11:43:38.287Z] ... sql:show stats_topn where db_name = 'test' and table_name = 't', args:[]
[2021-07-21T11:43:38.287Z]

LittleFall · 2021-07-21T12:06:46Z

2021-07-21T11:43:38.353Z] FAIL: show_stats_test.go:216: testShowStatsSuite.TestShowAnalyzeStatus
[2021-07-21T11:43:38.353Z]
[2021-07-21T11:43:38.353Z] show_stats_test.go:251:
[2021-07-21T11:43:38.353Z] c.Assert(len(result.Rows()), Equals, 1)
[2021-07-21T11:43:38.353Z] ... obtained int = 2
[2021-07-21T11:43:38.353Z] ... expected int = 1
[2021-07-21T11:43:38.353Z]

LittleFall

lgtm

ti-chi-bot · 2021-07-22T09:24:10Z

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

LittleFall

lgtm

LittleFall · 2021-07-22T09:27:27Z

[2021-07-21T11:43:36.886Z] FAIL: analyze_test.go:584: testSuite1.TestAnalyzeIncremental
[2021-07-21T11:43:36.886Z]
[2021-07-21T11:43:36.886Z] analyze_test.go:589:
[2021-07-21T11:43:36.886Z] s.testAnalyzeIncremental(tk, c)
[2021-07-21T11:43:36.886Z] /home/jenkins/agent/workspace/tidb_ghpr_check/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:63:
[2021-07-21T11:43:36.886Z] res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
[2021-07-21T11:43:36.886Z] ... obtained string = ""
[2021-07-21T11:43:36.886Z] ... expected string = "" +
[2021-07-21T11:43:36.886Z] ... "[test t p0 a 0 0 1 1 1 1 0]\n" +
[2021-07-21T11:43:36.886Z] ... "[test t p0 idx 1 0 1 1 1 1 0]\n"
[2021-07-21T11:43:36.886Z] ... sql:show stats_buckets, args:[]

windtalker

LGTM

ti-chi-bot · 2021-07-22T09:28:23Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

LittleFall
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

zhouqiang-cl · 2021-07-22T09:30:16Z

/merge

ti-chi-bot · 2021-07-22T09:30:19Z

This pull request has been accepted and is ready to merge.

Commit hash: 37c0580

LittleFall · 2021-07-22T14:20:26Z

waiting #25741

zhouqiang-cl · 2021-07-23T06:03:25Z

/merge

LittleFall · 2021-07-23T06:25:59Z

/merge

ti-chi-bot · 2021-07-23T06:26:04Z

This pull request has been accepted and is ready to merge.

Commit hash: e4cfcbe

zhouqiang-cl · 2021-07-23T06:46:53Z

/merge

ti-chi-bot · 2021-07-23T06:50:25Z

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zhouqiang-cl · 2021-07-23T07:07:01Z

/run-unit-tests

zhouqiang-cl · 2021-07-23T07:32:17Z

/run-unit-tests

cherry pick pingcap#26246 to release-5.1

fb74755

Signed-off-by: ti-srebot <[email protected]>

ti-srebot requested a review from a team as a code owner July 15, 2021 08:23

ti-srebot requested review from time-and-fate and removed request for a team July 15, 2021 08:23

ti-chi-bot added the do-not-merge/cherry-pick-not-approved label Jul 15, 2021

ti-srebot added sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.1-cherry-pick labels Jul 15, 2021

ti-srebot mentioned this pull request Jul 15, 2021

planner: add warnings about joins when tidb_enforce_mpp is enabled. #26246

Merged

10 tasks

ti-srebot requested review from hanfei1991 and windtalker July 15, 2021 08:23

ti-srebot assigned LittleFall Jul 15, 2021

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

7cb43ff

zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 20, 2021

ti-chi-bot removed the do-not-merge/cherry-pick-not-approved label Jul 20, 2021

LittleFall added 2 commits July 21, 2021 17:20

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

27dcec1

Update enforce_mpp_suite_out.json

a9a1498

LittleFall approved these changes Jul 22, 2021

View reviewed changes

LittleFall removed the sig/planner SIG: Planner label Jul 22, 2021

LittleFall approved these changes Jul 22, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

37c0580

windtalker approved these changes Jul 22, 2021

View reviewed changes

ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 22, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2021

ti-chi-bot added 3 commits July 22, 2021 17:40

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

b045473

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

ea712b7

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

fa9799a

ti-chi-bot added 4 commits July 22, 2021 22:22

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

e92254b

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

065cac0

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

1db79dc

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

49956b7

LittleFall added 2 commits July 23, 2021 14:22

cherry-pick pingcap#26487

74238c5

fix test

e4cfcbe

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

0e26df2

ti-chi-bot added 2 commits July 23, 2021 14:47

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

4749df0

Merge branch 'release-5.1' into release-5.1-76c5fd0e26b1

e0a43f5

ti-chi-bot merged commit 97650e8 into pingcap:release-5.1 Jul 23, 2021

LittleFall deleted the release-5.1-76c5fd0e26b1 branch July 23, 2021 09:34

zhouqiang-cl added the backport-5.1.1 label Jul 26, 2021

zhouqiang-cl added this to the v5.1.1 milestone Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: add warnings about joins when tidb_enforce_mpp is enabled. (#26246) #26272

planner: add warnings about joins when tidb_enforce_mpp is enabled. (#26246) #26272

ti-srebot commented Jul 15, 2021 •

edited

Loading

ti-srebot commented Jul 15, 2021

ti-srebot commented Jul 15, 2021

LittleFall commented Jul 21, 2021

LittleFall commented Jul 21, 2021

LittleFall left a comment

ti-chi-bot commented Jul 22, 2021

LittleFall left a comment

LittleFall commented Jul 22, 2021

windtalker left a comment

ti-chi-bot commented Jul 22, 2021

zhouqiang-cl commented Jul 22, 2021

ti-chi-bot commented Jul 22, 2021

LittleFall commented Jul 22, 2021 •

edited

Loading

zhouqiang-cl commented Jul 23, 2021

LittleFall commented Jul 23, 2021

ti-chi-bot commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

ti-chi-bot commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

planner: add warnings about joins when tidb_enforce_mpp is enabled. (#26246) #26272

planner: add warnings about joins when tidb_enforce_mpp is enabled. (#26246) #26272

Conversation

ti-srebot commented Jul 15, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-srebot commented Jul 15, 2021

ti-srebot commented Jul 15, 2021

LittleFall commented Jul 21, 2021

LittleFall commented Jul 21, 2021

LittleFall left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Jul 22, 2021

LittleFall left a comment

Choose a reason for hiding this comment

LittleFall commented Jul 22, 2021

windtalker left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Jul 22, 2021

zhouqiang-cl commented Jul 22, 2021

ti-chi-bot commented Jul 22, 2021

LittleFall commented Jul 22, 2021 • edited Loading

zhouqiang-cl commented Jul 23, 2021

LittleFall commented Jul 23, 2021

ti-chi-bot commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

ti-chi-bot commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

zhouqiang-cl commented Jul 23, 2021

ti-srebot commented Jul 15, 2021 •

edited

Loading

LittleFall commented Jul 22, 2021 •

edited

Loading