Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Revert tidb_allow_mpp modification for downgrade compatibility and add warnings for enforce mpp. #25302

Merged
merged 20 commits into from
Jun 11, 2021
Merged

planner: Revert tidb_allow_mpp modification for downgrade compatibility and add warnings for enforce mpp. #25302

merged 20 commits into from
Jun 11, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jun 9, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1905

Problem Summary: #24516 will let TiDB can't downgrade in some cases.

What is changed and how it works?

Proposal: Enofrce MPP

What's Changed: This PR reverted #24516, introduce a new variable tidb_enforce_mpp and some warning.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Revert

@LittleFall LittleFall requested a review from a team as a code owner June 9, 2021 09:39
@LittleFall LittleFall requested review from XuHuaiyu and removed request for a team June 9, 2021 09:39
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@LittleFall LittleFall requested a review from hanfei1991 June 10, 2021 06:42
@ti-chi-bot ti-chi-bot removed the sig/execution SIG execution label Jun 11, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 546c7de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@LittleFall
Copy link
Contributor Author

/run-unit-test

@github-actions github-actions bot added the sig/execution SIG execution label Jun 11, 2021
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 11, 2021 02:23
@ti-chi-bot ti-chi-bot merged commit 1f0245a into pingcap:master Jun 11, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 11, 2021
@LittleFall @ti-srebot
cherry pick pingcap#25302 to release-5.1
b75489d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 11, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25353

@LittleFall LittleFall deleted the enhance/mpp-warning branch June 11, 2021 02:31
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 11, 2021
@LittleFall @ti-srebot
cherry pick pingcap#25302 to release-5.0
ce92e3e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 11, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25358

ti-chi-bot pushed a commit that referenced this pull request Jun 11, 2021
@ti-srebot
planner: Revert tidb_allow_mpp modification for downgrade compatibi…
0dd2ca4 
…lity and add warnings for enforce mpp. (#25302) (#25353)
This was referenced Jun 11, 2021
Closed
Merged
This was referenced Jun 30, 2021
Closed
Closed
@LittleFall LittleFall mentioned this pull request Jul 14, 2021
Merged
10 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 15, 2021
Merged
10 tasks
LittleFall added a commit to LittleFall/tidb that referenced this pull request Jul 20, 2021
@LittleFall
planner: Revert tidb_allow_mpp modification for downgrade compatibi…
05ec09f 
…lity and add warnings for enforce mpp. (pingcap#25302)
@LittleFall LittleFall mentioned this pull request Jul 20, 2021
Closed
10 tasks
LittleFall added a commit to LittleFall/tidb that referenced this pull request Jul 20, 2021
@LittleFall
planner: Revert tidb_allow_mpp modification for downgrade compatibi…
d4bffc0 
…lity and add warnings for enforce mpp. (pingcap#25302)
@LittleFall LittleFall mentioned this pull request Jul 20, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@leiysky leiysky leiysky approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit warning about ineffective MPP plan generation when forcing MPP mode
6 participants
@LittleFall @ti-srebot @ti-chi-bot @hanfei1991 @leiysky @lzmhhh123