-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: handle other-conditions from subqueries correctly when constructing IndexJoin (#25817) #25818
planner: handle other-conditions from subqueries correctly when constructing IndexJoin (#25817) #25818
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@qw4990 you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f6b66a6
|
/merge |
cherry-pick #25817 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25818
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25799
Problem Summary: planner: handle other-conditions from subqueries correctly when constructing IndexJoin
What is changed and how it works?
When constructing IndexJoin, TiDB extracts equal expressions from other-conditions and converts them into eq-conditions to build hash keys.
If these equal expressions are from some
[not] in
sub-queries, this conversation may lead to wrong results sinceIndexJoin
cannot deal with NULL correctly in this case.This PR skips this conversation for equal expressions from
[not] in
sub-queries.Check List
Tests
Release note