Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: handle other-conditions from subqueries correctly when constructing IndexJoin (#25817) #25818

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 29, 2021

cherry-pick #25817 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25818

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25818:release-5.0-a0b97b0c962d

What problem does this PR solve?

Issue Number: close #25799

Problem Summary: planner: handle other-conditions from subqueries correctly when constructing IndexJoin

What is changed and how it works?

When constructing IndexJoin, TiDB extracts equal expressions from other-conditions and converts them into eq-conditions to build hash keys.

If these equal expressions are from some [not] in sub-queries, this conversation may lead to wrong results since IndexJoin cannot deal with NULL correctly in this case.

This PR skips this conversation for equal expressions from [not] in sub-queries.

Check List

Tests

  • Unit test

Release note

  • planner: handle other-conditions from subqueries correctly when constructing IndexJoin

@ti-srebot ti-srebot requested a review from a team as a code owner June 29, 2021 08:08
@ti-srebot ti-srebot requested review from rebelice and removed request for a team June 29, 2021 08:08
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Jun 29, 2021
@ti-srebot ti-srebot requested review from eurekaka and winoros June 29, 2021 08:08
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jun 29, 2021
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f6b66a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 29, 2021

/merge

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 29, 2021
@ti-chi-bot ti-chi-bot merged commit e1388a2 into pingcap:release-5.0 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants