planner: handle other-conditions from subqueries correctly when constructing IndexJoin #25817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/bugfix
ti-chi-bot
added
the
size/S
winoros
approved these changes
Jun 29, 2021
eurekaka
reviewed
Jun 29, 2021
eurekaka
approved these changes
Jun 29, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
1 similar comment
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 7df47a0
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 29, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0 in PR #25818 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 29, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.1 in PR #25819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #25799
Problem Summary: planner: handle other-conditions from subqueries correctly when constructing IndexJoin
What is changed and how it works?
When constructing IndexJoin, TiDB extracts equal expressions from other-conditions and converts them into eq-conditions to build hash keys.
If these equal expressions are from some
[not] insub-queries, this conversation may lead to wrong results sinceIndexJoincannot deal with NULL correctly in this case.This PR skips this conversation for equal expressions from
[not] insub-queries.Check List
Tests
Release note