Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: dump FMSketch to KV only for partition table with dynamic prune mode (#24453) #24539

Closed
wants to merge 9 commits into from
Closed

statistics: dump FMSketch to KV only for partition table with dynamic prune mode (#24453) #24539

wants to merge 9 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 11, 2021 •
edited
Loading

cherry-pick #24453 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24539

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24539:release-5.0-3fed33fc1735

What problem does this PR solve?

Issue Number: close #24401

Problem Summary:

What is changed and how it works?

What's Changed:

We only dump FMSketch to KV for partition table with dynamic prune mode.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • statistics: dump FMSketch to KV only for partition table with dynamic prune mode

@ti-srebot ti-srebot requested review from a team as code owners May 11, 2021 04:48
@ti-srebot ti-srebot requested review from wshwsh12 and lzmhhh123 and removed request for a team May 11, 2021 04:48
@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
@ti-srebot ti-srebot added component/statistics sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels May 11, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 11, 2021
@ti-srebot
Copy link
Contributor Author

@rebelice you're already a collaborator in bot's repo.

@time-and-fate
Copy link
Member

need to resolve conflicts.
@rebelice

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2021
@wshwsh12 wshwsh12 removed their request for review June 3, 2021 03:54
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 21, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c5e4140

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@lzmhhh123 lzmhhh123 removed their request for review July 5, 2021 02:09
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/merge

@eurekaka
Copy link
Contributor

eurekaka commented Sep 2, 2021

Not critical enough, this PR will not be merged into 5.0.

@eurekaka eurekaka closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees

@rebelice rebelice

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/statistics sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @time-and-fate @qw4990 @zhouqiang-cl @eurekaka @winoros @rebelice