Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: dump FMSketch to KV only for partition table with dynamic prune mode #24453

Merged
merged 16 commits into from
May 11, 2021
Merged

statistics: dump FMSketch to KV only for partition table with dynamic prune mode #24453

merged 16 commits into from
May 11, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented May 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #24401

Problem Summary:

What is changed and how it works?

What's Changed:

We only dump FMSketch to KV for partition table with dynamic prune mode.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • statistics: dump FMSketch to KV only for partition table with dynamic prune mode

@rebelice rebelice requested review from a team as code owners May 7, 2021 07:36
@rebelice rebelice requested review from wshwsh12 and time-and-fate and removed request for a team May 7, 2021 07:36
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021
@rebelice rebelice requested review from qw4990 and winoros May 7, 2021 07:37
@github-actions github-actions bot added the sig/execution SIG execution label May 7, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2021
@qw4990 qw4990 mentioned this pull request May 7, 2021
Closed
60 tasks
qw4990
qw4990 reviewed May 7, 2021
View reviewed changes
statistics/handle/handle.go Outdated Show resolved Hide resolved
@ichn-hu ichn-hu mentioned this pull request May 7, 2021
Closed
@time-and-fate
Copy link
Member

Seems TestDuplicateFMSketch and TestDuplicateFMSketch failed because we didn't enable dynamic pruning in them.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@qw4990
Copy link
Contributor

qw4990 commented May 10, 2021

@time-and-fate PTAL

time-and-fate
time-and-fate approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021
@rebelice
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cfe6e4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@qw4990
Copy link
Contributor

qw4990 commented May 10, 2021

/merge

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@qw4990
Copy link
Contributor

qw4990 commented May 11, 2021

/merge

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@Rustin170506
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 3fed33f into pingcap:master May 11, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 11, 2021
@rebelice @ti-srebot
cherry pick pingcap#24453 to release-5.0
eb7e3b5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/statistics needs-cherry-pick-release-5.0 sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write FM Sketch data to KV even if the table isn't partition table or in static partition prune mode
6 participants
@rebelice @time-and-fate @qw4990 @ti-chi-bot @Rustin170506 @ti-srebot