Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan (#24157) #24488

Closed
wants to merge 4 commits into from
Closed

planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan (#24157) #24488

wants to merge 4 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 8, 2021 •
edited
Loading

cherry-pick #24157 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24488

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24488:release-5.0-e79fa8c6b654

What problem does this PR solve?

Problem Summary:
Sometimes optimizer doesn't choose mpp plan. We lack a way to suggest optimizer choose mpp. I think tiflash_concurrency_factor is a good variable to charge this.

What is changed and how it works?

What's Changed:
The final mpp plan's cost will devide this factor.

How it Works:

Related changes

Check List

Tests

  • Unit test (we can detect cost changes)

Release note

  • planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan

@ti-srebot ti-srebot requested a review from a team as a code owner May 8, 2021 08:10
@ti-srebot ti-srebot requested review from rebelice and removed request for a team May 8, 2021 08:10
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 8, 2021
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels May 8, 2021
@ti-srebot ti-srebot requested review from fzhedu, qw4990 and XuHuaiyu May 8, 2021 08:11
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 8, 2021
@ti-srebot
Copy link
Contributor Author

@hanfei1991 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2021
@fzhedu
Copy link
Contributor

fzhedu commented May 12, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@fzhedu: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2021
@qw4990
Copy link
Contributor

qw4990 commented May 13, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c259a5c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2021
@hanfei1991
Copy link
Member

/merge

@qw4990
Copy link
Contributor

qw4990 commented May 13, 2021

/merge

windtalker pushed a commit to windtalker/tidb that referenced this pull request May 18, 2021
cherry pick pingcap#24488
0cfe1e8
@hanfei1991 hanfei1991 closed this Jun 4, 2021
@LittleFall LittleFall deleted the release-5.0-e79fa8c6b654 branch July 20, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice Awaiting requested review from rebelice

@fzhedu fzhedu Awaiting requested review from fzhedu

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@hanfei1991 hanfei1991

Labels
do-not-merge/cherry-pick-not-approved sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @fzhedu @ti-chi-bot @qw4990 @hanfei1991 @lzmhhh123 @LittleFall