-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan #24157
planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan #24157
Conversation
@@ -102,7 +102,7 @@ | |||
{ | |||
"SQL": "explain format = 'verbose' select count(*) from t2 group by a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use brief
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verbose conflicts with brief, you cannot set them at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@fzhedu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/LGTM |
@fzhedu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@qw4990: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 429f12b
|
/merge |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #24488 |
What problem does this PR solve?
Problem Summary:
Sometimes optimizer doesn't choose mpp plan. We lack a way to suggest optimizer choose mpp. I think tiflash_concurrency_factor is a good variable to charge this.
What is changed and how it works?
What's Changed:
The final mpp plan's cost will devide this factor.
How it Works:
Related changes
Check List
Tests
Release note